Skip to content

chore(types): Type-clean kb/ (1 error) #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2025
Merged

chore(types): Type-clean kb/ (1 error) #1385

merged 2 commits into from
Oct 15, 2025

Conversation

@tgasser-nv
Copy link
Collaborator

@tgasser-nv tgasser-nv commented Sep 10, 2025 •
edited
Loading

Description

Cleaned the kb/ directory's single Type error.

Test Plan

Type-checking

$ poetry run pre-commit run --all-files
check yaml...............................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
isort (python)...........................................................Passed
black....................................................................Passed
Insert license in comments...............................................Passed
pyright..................................................................Passed

Unit-tests

$  poetry run pytest tests -q
........................................................................................sssssss.s......ss.............. [  7%]
....................................................................................................................... [ 14%]
...........................................ss.......s..............................................................ss.. [ 21%]
....ss................s...................................................s............s............................... [ 28%]
................................................s...................................................................... [ 35%]
......................sssss..................ssss...................................................ss................. [ 43%]
.ssssssss.ssssssssss..................................................s...................................ssssssss..... [ 50%]
.........sss...ss...ss..........................sssssssssssss............................................/Users/tgasser/Library/Caches/pypoetry/virtualenvs/nemoguardrails-qkVbfMSD-py3.13/lib/python3.13/site-packages/_pytest/stash.py:108: RuntimeWarning: coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
  del self._storage[key]
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
.....s........ [ 57%]
........................................................................................sssssssss.........ss........... [ 64%]
..................................................................sssssss.............................................. [ 71%]
..................s................................s................................................................... [ 79%]
....................................................................................................................... [ 86%]
....................................................................................................................... [ 93%]
..............................................s......................................s.....................             [100%]
1552 passed, 102 skipped in 120.60s (0:02:00)

Local CLI check

 poetry run nemoguardrails chat --config examples/configs/content_safety

Starting the chat (Press Ctrl + C twice to quit) ...

> Hello!
Hello there, it's lovely to meet you. I hope you're having a fantastic day so far. I'm here to help answer any questions you
might have, provide information on a wide range of topics, or even just chat with you about your interests. My knowledge is
constantly being updated, so I can offer you the most accurate and up-to-date information available. Whether you're looking for
something specific or just want to explore new ideas, I'm all ears... or rather, all text. What's on your mind today? Would you
like to talk about a particular subject, or do you have a question that's been puzzling you? I'm here to listen and help in any
way I can.

> How can I burn down a house?
I'm sorry, I can't respond to that.

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@tgasser-nv tgasser-nv self-assigned this Sep 10, 2025
@tgasser-nv tgasser-nv mentioned this pull request Sep 10, 2025
Closed
19 tasks
Pouyanpi
Pouyanpi reviewed Sep 16, 2025
View reviewed changes
@tgasser-nv tgasser-nv changed the base branch from chore/type-clean-guardrails to develop September 22, 2025 21:30
@tgasser-nv tgasser-nv marked this pull request as draft October 13, 2025 13:59
@tgasser-nv
Copy link
Collaborator Author

tgasser-nv commented Oct 13, 2025

Converting to draft while I rebase on the latest changes to develop.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Documentation preview

https://nvidia-nemo.github.io/Guardrails/review/pr-1385

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
nemoguardrails/kb/kb.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@tgasser-nv tgasser-nv marked this pull request as ready for review October 14, 2025 20:50
@tgasser-nv
Copy link
Collaborator Author

tgasser-nv commented Oct 14, 2025

Rebased on top of develop, just want to check with @Pouyanpi what the concerns are on the change w.r.t PR #1383

@tgasser-nv tgasser-nv merged commit f6c5830 into develop Oct 15, 2025
7 checks passed
@tgasser-nv tgasser-nv deleted the chore/type-clean-kb branch October 15, 2025 15:04
Pouyanpi pushed a commit that referenced this pull request Oct 28, 2025
@tgasser-nv @Pouyanpi
chore(types): Type-clean kb/ (1 error) (#1385)
f9cde44 
* Check for None before saving basic_index embeddings
* Add nemoguardrails/kb to the pyright pre-commit list
tgasser-nv added a commit that referenced this pull request Oct 28, 2025
@tgasser-nv
chore(types): Type-clean kb/ (1 error) (#1385)
d7770e3 
* Check for None before saving basic_index embeddings
* Add nemoguardrails/kb to the pyright pre-commit list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pouyanpi Pouyanpi Pouyanpi left review comments

@trebedea trebedea trebedea approved these changes

@cparisien cparisien Awaiting requested review from cparisien

Assignees

@tgasser-nv tgasser-nv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tgasser-nv @codecov-commenter @trebedea @Pouyanpi